GabdaSilva07 / Ellis-BackEnd

0 stars 0 forks source link

Sweep: Fix the Issue with Firebase Service #24

Open GabdaSilva07 opened 1 year ago

GabdaSilva07 commented 1 year ago
Checklist - [X] `EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs` ✅ Commit [`e428421`](https://github.com/GabdaSilva07/Ellis-BackEnd/commit/e428421762b873a9ddca2dcf995b6f2a9e8662ac) - [X] `EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs` ✅ Commit [`3534169`](https://github.com/GabdaSilva07/Ellis-BackEnd/commit/3534169aefcbf6a8a8148f8f951cf31579bdf7eb) - [X] `EllisFitnessApp/API/Controllers/WeatherForecastController.cs` ❌ Failed - [X] `EllisFitnessApp/Logger/Logger.cs` ✅ Commit [`b38bed3`](https://github.com/GabdaSilva07/Ellis-BackEnd/commit/b38bed359b592fe7c8d9fadbd5aafe7490d86c9c)
sweep-ai[bot] commented 1 year ago

Here's the PR! https://github.com/GabdaSilva07/Ellis-BackEnd/pull/26.

⚡ Sweep Free Trial: I'm creating this ticket using GPT-4. You have 3 GPT-4 tickets left for the month and 2 for the day. For more GPT-4 tickets, visit [our payment portal.](https://buy.stripe.com/6oE5npbGVbhC97afZ4)

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/GabdaSilva07/Ellis-BackEnd/blob/cab7c19b4a7bef335f2da98c04e7a72691296765/EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs#L1-L56 https://github.com/GabdaSilva07/Ellis-BackEnd/blob/cab7c19b4a7bef335f2da98c04e7a72691296765/EllisFitnessApp/API/Controllers/WeatherForecastController.cs#L1-L66 https://github.com/GabdaSilva07/Ellis-BackEnd/blob/cab7c19b4a7bef335f2da98c04e7a72691296765/EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs#L22-L88 https://github.com/GabdaSilva07/Ellis-BackEnd/blob/cab7c19b4a7bef335f2da98c04e7a72691296765/EllisFitnessApp/API/Test/Firebase_Auth_Module_Documentation.md#L1-L55 https://github.com/GabdaSilva07/Ellis-BackEnd/blob/cab7c19b4a7bef335f2da98c04e7a72691296765/EllisFitnessApp/Logger/Logger.cs#L1-L179

Step 2: ⌨️ Coding

trunk init 1/7 ✓
⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
⣯ Downloading Trunk 1.16.0...
⣟ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 12 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 2.4.9 (1 docker, 6 json, 2 yaml files)
  git-diff-check (72 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  prettier 3.0.3 (1 javascript, 5 json, 2 markdown, 2 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 2 yaml files)
  trufflehog 3.57.0 (73 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 2/7 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 3/7 ❌ (`1`)

  ISSUES  
EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs:25:1
 25:1  high   trailing whitespace.  git-diff-check/error
 28:1  high   trailing whitespace.  git-diff-check/error
 32:1  high   trailing whitespace.  git-diff-check/error
 38:1  high   trailing whitespace.  git-diff-check/error
 57:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 5 new issues
trunk fmt EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 4/7 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 5/7 ❌ (`1`)

  ISSUES  
EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs:53:1
 53:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 1 new issue
trunk fmt EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 6/7 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/FCM.Messaging/FirebaseMessagingService.cs 7/7 ✓

Checked 1 file
✔ No issues

trunk init 1/9 ✓
⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
⣯ Downloading Trunk 1.16.0...
⣟ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 12 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 2.4.9 (1 docker, 6 json, 2 yaml files)
  git-diff-check (72 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  prettier 3.0.3 (1 javascript, 5 json, 2 markdown, 2 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 2 yaml files)
  trufflehog 3.57.0 (73 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 2/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 3/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs:42:1
 42:1  high   trailing whitespace.  git-diff-check/error
 46:1  high   trailing whitespace.  git-diff-check/error
 48:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 3 new issues
trunk fmt EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 4/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 5/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs:42:1
 42:1  high   trailing whitespace.  git-diff-check/error
 47:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 2 new issues
trunk fmt EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 6/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 7/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs:42:1
 42:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 1 new issue
trunk fmt EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 8/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Authentification/FirebaseAuthMiddleware.cs 9/9 ✓

Checked 1 file
✔ No issues

trunk init 1/3 ✓
⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
⣯ Downloading Trunk 1.16.0...
⣟ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 12 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 2.4.9 (1 docker, 6 json, 2 yaml files)
  git-diff-check (72 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  prettier 3.0.3 (1 javascript, 5 json, 2 markdown, 2 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 2 yaml files)
  trufflehog 3.57.0 (73 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt EllisFitnessApp/API/Controllers/WeatherForecastController.cs 2/3 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/API/Controllers/WeatherForecastController.cs 3/3 ✓

Checked 1 file
✔ No issues

trunk init 1/9 ✓
⡿ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
⣷ Downloading Trunk 1.16.0...
⣯ Downloading Trunk 1.16.0...
⣟ Downloading Trunk 1.16.0...
⡿ Downloading Trunk 1.16.0...
⢿ Downloading Trunk 1.16.0...
⣻ Downloading Trunk 1.16.0...
⣽ Downloading Trunk 1.16.0...
⣾ Downloading Trunk 1.16.0...
✔ Downloading Trunk 1.16.0... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 12 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 2.4.9 (1 docker, 6 json, 2 yaml files)
  git-diff-check (72 files)
  hadolint 2.12.0 (1 docker file) (created .hadolint.yaml)
  markdownlint 0.37.0 (2 markdown files) (created .markdownlint.yaml)
  osv-scanner 1.4.0 (1 lockfile file)
  prettier 3.0.3 (1 javascript, 5 json, 2 markdown, 2 yaml files)
  taplo 0.8.1 (1 toml file)
  terrascan 1.18.3 (1 docker file)
  trivy 0.45.1 (1 docker, 1 lockfile, 2 yaml files)
  trufflehog 3.57.0 (73 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt EllisFitnessApp/Logger/Logger.cs 2/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Logger/Logger.cs 3/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Logger/Logger.cs:67:1
 67:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 1 new issue
trunk fmt EllisFitnessApp/Logger/Logger.cs 4/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Logger/Logger.cs 5/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Logger/Logger.cs:67:1
 67:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 1 new issue
trunk fmt EllisFitnessApp/Logger/Logger.cs 6/9 ✓

Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Logger/Logger.cs 7/9 ❌ (`1`)

  ISSUES  
EllisFitnessApp/Logger/Logger.cs:32:1
 32:1  high   trailing whitespace.  git-diff-check/error
 67:1  high   trailing whitespace.  git-diff-check/error
Checked 1 file
✖ 2 new issues
trunk fmt EllisFitnessApp/Logger/Logger.cs 8/9 ✓
Found no applicable linters for the requested path
trunk check --fix EllisFitnessApp/Logger/Logger.cs 9/9 ✓

Checked 1 file
✔ No issues


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/fix-firebase-service-issue.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord