gitguardian[bot]
commented
1 year ago ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [8224621](https://dashboard.gitguardian.com/incidents/8224621?occurrence=115727375) | Google Cloud Keys | 3e07c63bda317f8e7f727b92ada9e4a663b59330 | EllisFitnessApp/FirebaseService/firebase.json | [View secret](https://github.com/GabdaSilva07/Ellis-BackEnd/commit/3e07c63bda317f8e7f727b92ada9e4a663b59330#diff-c4f101b59bcc3c28208393bc93b416553d0d231b8fb8debe94abf8813d2b8e03R5) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googlecloud#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Description
This PR addresses the code review and optimization requested in issue #5. The main areas of focus were the usage of the Serilog library in the Logger class, the inheritance in the Trainer and User classes, and the design of the domain models for MongoDB. The changes made in this PR aim to improve the efficiency and correctness of the code.
Summary of Changes
Please review the changes and provide any feedback or further improvements that may be needed.
Fixes #5.
To checkout this PR branch, run the following command in your terminal:
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: