GabeDuarteM / semantic-release-chrome

Set of semantic-release plugins for publishing a Chrome extension release
https://www.npmjs.com/package/semantic-release-chrome
MIT License
43 stars 16 forks source link

feat(target): Add target local #106

Closed pohy closed 1 year ago

pohy commented 1 year ago

Pull Request

Description

This PR adds another flag to the target option. Namely, target: 'local'.
When set, checking for environment variables is skipped in the verifyConditions step. As well as uploading the bundle to the Chrome store, during the publish step.

Why

It is sometimes desirable to skip publishing to Chrome store, but still update the version in manifest.json and obtain the zipped bundle. I.e. for publishing on the GitLab/Github releases page only.

Type of change

Release for testing

https://www.npmjs.com/package/@pohy/semantic-release-chrome

Checklist

HenryC-3 commented 1 year ago

This is great, please merge it @GabrielDuarteM

GabeDuarteM commented 1 year ago

Hey @pohy 👋

Thank you for the PR!

I think this behaviour used to be possible before when you declared the plugin list. They used to allow you to opt-in/out of specific steps when declaring the plugin list (example here), but I can't find that anymore on the docs, so I guess at some point it was removed.

In any case, the code looks good to me. Not sure why the build pipeline is not being reported here, but I ran them locally and they passed, so I'll just merge it 👍

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pohy commented 1 year ago

Thanks for merging! 🙏