search

GabeDuarteM / semantic-release-chrome

Set of semantic-release plugins for publishing a Chrome extension release
https://www.npmjs.com/package/semantic-release-chrome
MIT License
43 stars 16 forks source link

fix: read `statusDetail` instead of `statusList` #44

Closed exKAZUu closed 4 years ago

exKAZUu commented 4 years ago

Pull Request

Related issue

41

Description

This PR fixes #41 by reading the correct property statusDetail instead of statusList.

Why

The correct property name seems statusDetail described in https://developer.chrome.com/webstore/webstore_api/items/publish

How

I've read https://developer.chrome.com/webstore/webstore_api/items/publish and corrected the property name.

Screenshots

[4:39:16 AM] [semantic-release] › ✖  An error occurred while running semantic-release: { TypeError: Cannot read property '0' of undefined
    at publish (/home/circleci/project/node_modules/semantic-release-chrome/dist/publish.js:60:44)
    at process._tickCallback (internal/process/next_tick.js:68:7) pluginName: 'semantic-release-chrome' }
{ TypeError: Cannot read property '0' of undefined
    at publish (/home/circleci/project/node_modules/semantic-release-chrome/dist/publish.js:60:44)
    at process._tickCallback (internal/process/next_tick.js:68:7) pluginName: 'semantic-release-chrome' }error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How has this been tested

Sorry, I don't know how to test this package. If needed, please help me to test this change.

Type of change

Checklist

GabeDuarteM commented 4 years ago

Thank you for the PR! Code-wise it looks good to me, I just didn't merge it yet because I wanted to test it first, and to do that I'd like to release a dummy extension. Unfortunately, I didn't find the time yet to do it.

By any chance, have you tried releasing any extension with these changes?

exKAZUu commented 4 years ago

Okay. Unfortunately, I didn't and I have no plan most recently, but I definitely will do that at some time.

exKAZUu commented 4 years ago

@GabrielDuarteM I now confirm my change fixes the issue (though I find another issue #46). I successfully uploaded a new version of my extension (https://github.com/WillBooster/plantuml-visualizer) by using semantic-release-chrome with this patch (https://github.com/WillBooster/plantuml-visualizer/blob/master/package.json#L60).

GabeDuarteM commented 4 years ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: