"on" is not a valid RGB setting anymore?

[GabeKnuth]

I swear this show worked before. Logs attached. Here's the show that's crashing it: Archive 11.zip

#show_version=4
# Everything Off
- time: 0
  leds:
    (right): off
    (center): off
    (left): off
    (gi): off

# First strobe in video
- time: 3.933
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 4.2
  leds:
    l_lower_right_flasher: on%50
    l_lower_left_flasher: on%50
    l_right_ramp_flasher: on%50
    l_left_ramp_flasher: on%50
- time: 4.35
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 4.733
  leds:
    l_lower_right_flasher: off
    l_lower_left_flasher: off
    l_right_ramp_flasher: off
    l_left_ramp_flasher: off

# Second strobe in video
- time: 6.133
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 6.5
  leds:
    l_lower_right_flasher: on%50
    l_lower_left_flasher: on%50
    l_right_ramp_flasher: on%50
    l_left_ramp_flasher: on%50
- time: 6.85
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 7.1
  leds:
    l_lower_right_flasher: off
    l_lower_left_flasher: off
    l_right_ramp_flasher: off
    l_left_ramp_flasher: off

# Third strobe
- time: 8.3
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 8.6
  leds:
    l_lower_right_flasher: on%50
    l_lower_left_flasher: on%50
    l_right_ramp_flasher: on%50
    l_left_ramp_flasher: on%50
- time: 8.75
  leds:
    l_lower_right_flasher: on
    l_lower_left_flasher: on
    l_right_ramp_flasher: on
    l_left_ramp_flasher: on
- time: 9.1
  leds:
    l_lower_right_flasher: off
    l_lower_left_flasher: off
    l_right_ramp_flasher: off
    l_left_ramp_flasher: off

# Light up playfield again
- time: 9.233
  leds:
    (right): on-f2433ms
    (center): on-f2433ms
    (left): on-f2433ms
    (gi): on-f2433ms
- time: 11.666
  leds:
    (right): off-f200ms
    (center): off-f200ms
    (left): off-f200ms
    (gi): off-f200ms
  events:
    mr_launch_balls
- time: 12.000

[toomanybrians]

It's due to the on%50 entries. Since those are known LEDs, can you just use the real colors?

Fixing this is more than a 5min thing due to the fact that resolving "on" to a color and the brightness % are done differently in different places, and combining them breaks each others' functionality. I can make a quick hack, but it would be ugly, so we should just fix this properly.

[jabdoa2]

Yeah. white%50 should work. on%50 is also semantically weird.

[GabeKnuth]

I can do this for now, but the purpose of "on" was because I have different default colors specified for LEDs, and I wanted something that worked without having to go find the colors.

Also, I'm 90% sure this worked a week ago. Did something change?

[jabdoa2]

I doubt that this worked. On and off are a bit special. We would have to replace on to a color first and then evaluate the color again with brightness which would be a bit odd

[GabeKnuth]

You're right. I had a video shot on March 10th, and that config change wasn't made until the 12th. We can revisit this another time.

On Mon, Mar 27, 2017 at 3:00 PM, jabdoa2 notifications@github.com wrote:

I doubt that this worked. On and off are a bit special. We would have to replace on to a color first and then evaluate the color again with brightness which would be a bit odd

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GabeKnuth/BnD/issues/31#issuecomment-289568133, or mute the thread https://github.com/notifications/unsubscribe-auth/ALU2eiSIY7wbfjrM0u61z6-BQVIBqHVrks5rqBVtgaJpZM4Mpy4b .