Closed GabeKnuth closed 7 years ago
It's due to the on%50
entries. Since those are known LEDs, can you just use the real colors?
Fixing this is more than a 5min thing due to the fact that resolving "on" to a color and the brightness % are done differently in different places, and combining them breaks each others' functionality. I can make a quick hack, but it would be ugly, so we should just fix this properly.
Yeah. white%50 should work. on%50 is also semantically weird.
I can do this for now, but the purpose of "on" was because I have different default colors specified for LEDs, and I wanted something that worked without having to go find the colors.
Also, I'm 90% sure this worked a week ago. Did something change?
I doubt that this worked. On and off are a bit special. We would have to replace on to a color first and then evaluate the color again with brightness which would be a bit odd
You're right. I had a video shot on March 10th, and that config change wasn't made until the 12th. We can revisit this another time.
On Mon, Mar 27, 2017 at 3:00 PM, jabdoa2 notifications@github.com wrote:
I doubt that this worked. On and off are a bit special. We would have to replace on to a color first and then evaluate the color again with brightness which would be a bit odd
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GabeKnuth/BnD/issues/31#issuecomment-289568133, or mute the thread https://github.com/notifications/unsubscribe-auth/ALU2eiSIY7wbfjrM0u61z6-BQVIBqHVrks5rqBVtgaJpZM4Mpy4b .
I swear this show worked before. Logs attached. Here's the show that's crashing it: Archive 11.zip