search

GabiGrin / vscode-auto-run-command

Run a vscode command when it starts. Made to run wallaby.js automatically when a project is opened
https://marketplace.visualstudio.com/items?itemName=gabrielgrinberg.auto-run-command#review-details
MIT License
22 stars 15 forks source link

Add ability to pass arguments to commands #11

Closed breathe closed 6 years ago

breathe commented 7 years ago

Split command string into an array with space separator and pass to executeCommand as an array so that commands with arguments are correctly interpreted.

Should be backwards compatible and shouldn't change behavior of any existing use cases.

breathe commented 7 years ago

@GabiGrin Any interest in accepting this? Its a small patch to review ...

Does this project have a license anywhere? If the project is no longer being developed -- I'll fork it for my own use if the license allows ...

Thanks.

GabiGrin commented 7 years ago

@breathe sorry, just saw this now. Thanks for the help The build is failing after this, and unfortunately I don't have time to check this. Can you try making it pass so I can merge safely?

breathe commented 7 years ago

@GabiGrin I'm not sure why the tests are failing ... they pass when run locally ... It seems like there is something wrong in the travis environment?

GabiGrin commented 6 years ago

Hi @breathe Sorry for the long delay! I'll merge this and publish soon