Gabriel95 / scalafx

Automatically exported from code.google.com/p/scalafx
Other
0 stars 0 forks source link

Mentions of JAVAFX_HOME are probably outdated #17

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
(Just mailed this to the dev list, but adding here too as a reminder.)

The issue is that references to JAVAFX_HOME should (imho) be replaced by 
references to JAVA_HOME, now that JavaFX is being distributed as part of Java. 
However, it may not be that simple (i.e. due to multiple build systems being 
supported - why not just focus on one?)

Pls. see: 
http://stackoverflow.com/questions/12917101/compiling-scalafx-for-java-7u7-that-
contains-javafx-2-2-on-os-x

What is definitely wrong is asking to set JAVAFX_HOME in the README.txt file, 
and then using sbt for compilation. 'build.sbt' no longer follows that env.var. 
but JAVA_HOME instead. However, 'gradle' seems to be using JAVAFX_HOME.

Before a real release is done, someone should fix these to be consistent. 

<<
$ grep -R JAVAFX_HOME *
README.txt:  1) Set the JAVAFX_HOME environment variable. 
README.txt:    export JAVAFX_HOME=/Path/To/javafx-sdk2.1.0-beta
build.gradle:    final javafxHome = System.env['JAVAFX_HOME']
build.gradle:                 |  Please set the environment variable JAVAFX_HOME
build.sbt:// Important - Set the JAVAFX_HOME environment variable to the root 
of your JavaFX installation for this script to work
build.sbt:// unmanagedJars in Compile += 
Attributed.blank(file(System.getenv("JAVAFX_HOME") + "/rt/lib/jfxrt.jar"))
<<

>What is the expected output? What do you see instead?

README information and actual build procedure must be in sync.

>What version of the product are you using? On what operating system?

OS X 10.8.2, Scala 2.9.2, SBT 0.12.1

Original issue reported on code.google.com by akau...@gmail.com on 26 Dec 2012 at 3:53

GoogleCodeExporter commented 8 years ago
Peter Pilgrim commited build.gradle corrections in 28/12/2012 (see 
http://code.google.com/p/scalafx/source/detail?spec=svn7ea1823cefc734bc31a7d994f
f6835031be9b165&r=e31c5d763b5a75c4c26c7f04585a585e4e0f9357 ). Changes in 
build.sbt and README are pending yet. However, how sbt script not really uses 
JAVAFX_HOME (its line was commented by Peter - see 
http://code.google.com/p/scalafx/source/detail?spec=svn7ea1823cefc734bc31a7d994f
f6835031be9b165&r=0dc129b6b8e6736bf990f905cc98891d34f77f4c), probably it will 
be necessary just drop the 2 lines where it appears. Therefore just README 
would really need be changed, removing references to JAVAFX_HOME.

Original comment by rafael.a...@gmail.com on 3 Jan 2013 at 1:10

GoogleCodeExporter commented 8 years ago
The new split to multiple subprojects seems to have addressed this as well. 

Original comment by akau...@gmail.com on 19 Jan 2013 at 6:17

GoogleCodeExporter commented 8 years ago
(please close - I don't seem to have power for that?)

Original comment by akau...@gmail.com on 19 Jan 2013 at 6:18

GoogleCodeExporter commented 8 years ago
closing as per request from Asko Kauppi

Original comment by Alain.Fa...@gmail.com on 22 Jan 2013 at 6:35

GoogleCodeExporter commented 8 years ago
closing as per request from Asko Kauppi

Original comment by Alain.Fa...@gmail.com on 22 Jan 2013 at 6:35