search

GabrielBB / xvfb-action

Run your tests headlessly ❌🖥️
https://github.com/marketplace/actions/gabrielbb-xvfb-action
MIT License
140 stars 20 forks source link

Windows detection not working 100% #11

Closed kriegfrj closed 3 years ago

kriegfrj commented 4 years ago

I just found this action and it is exactly what I needed - thanks!

However, I found that the windows detection wasn't working properly - I had to split out Windows from the build matrix. I suspect this is because it's using cygwin or some Unix-like shell. See bndtools/bnd#4163.

This error is reported against 1.2. I have since had to downgrade it to 1.0 due to #10.

kriegfrj commented 4 years ago

I have just verified that there are still problems with the auto-detection on windows with 1.0 - see the following output (from https://github.com/kriegfrj/bnd/actions/runs/146783355):

Unable to locate executable file: d:\a\bnd\bnd\.github\scripts\build.sh. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also verify the file has a valid extension for an executable file.

The same command works fine when run without xvfg-action.

GabrielBB commented 4 years ago

Hi @kriegfrj The problems with 1.2 were fixed in v1.4. Maybe you can test using working_directory with this new version?

GabrielBB commented 3 years ago

v1 tag updated