GabrielBB / xvfb-action

Run your tests headlessly ❌🖥️
https://github.com/marketplace/actions/gabrielbb-xvfb-action
MIT License
140 stars 20 forks source link

FYI: xvfb is provided in standard linux image now #2

Closed 3cp closed 4 years ago

3cp commented 4 years ago

Thanks for this great package. After play with it for a while, I read from the job logs that it seems xvfb is already installed in standard linux image.

So I tried following setup without using this package, and it worked.

- run: xvfb-run -a npm test
  if: runner.os == 'Linux'
- run: npm test
  if: runner.os != 'Linux'
GabrielBB commented 4 years ago

@3cp Wow, for real? I have to test that. That would make this package pretty much useless

3cp commented 4 years ago

They probably added the xvfb package after user feedback. But it's not obviously documented anywhere. They should have a section on how to deal with various browser test.

GabrielBB commented 4 years ago

@3cp Yeah, they added the package. That’s great! I should add a disclaimer to this project.

Thanks for notifying

evandrocoan commented 4 years ago

What/where is the disclainer?

ShaMan123 commented 1 year ago

This should be PINNED