Segfaults on windows starting ~2022/01/30

[tlambert03]

Yesterday, we started seeing all of our windows tests fail immediately with: failed with exit code 3221225477 (see for example: https://github.com/napari/napari/actions/runs/1768885019)

It appears that manually performing the os check, and not using this action on windows fixes it:

      - name: Test with tox
        uses: GabrielBB/xvfb-action@v1
        if: runner.os == 'Linux'
        with:
          run: tox

see https://github.com/napari/napari/pull/4031/

Any thoughts on what might have changed in the last couple days that would break the "no-op" functionality on windows for this action?

[tlambert03]

@GabrielBB, any thoughts here? I'm more than happy to help debug. we've got a number of repos using this action, all of which are failing to pass on windows at the moment... so I've got some motivation to work on it :) would you suspect an update to the @actions/exec pin would do anything?

[tlambert03]

i was able to narrow it down to a python environment related issue. Something has changed, but I'm not sure where.
Whereas this used to work to test something (for example, with pytest-qt driving a headless Qt test):

      # using actions/setup-python above...
      - uses: GabrielBB/xvfb-action@v1
        with:
          run: pytest

in the last few days, it now requires:

      - uses: GabrielBB/xvfb-action@v1
        with:
          run: python -m pytest

I think it's safe to say it's unrelated to xvfb-action, so will close this.