GabrielBB / xvfb-action

Run your tests headlessly ❌🖥️
https://github.com/marketplace/actions/gabrielbb-xvfb-action
MIT License
140 stars 20 forks source link

String literals escaping #3

Open aminya opened 4 years ago

aminya commented 4 years ago

Is xvfb using another shell instead of bash?

I cannot escape my string literals while I have set bash as my default shell

defaults:
  run:
    shell: bash
      - name: Run Graphical test
        uses: GabrielBB/xvfb-action@v1.0
        with:
          run: julia --project -e 'include("deps/SnoopCompile/snoopi_bot.jl"); include("deps/SnoopCompile/snoopi_bench.jl");'
SimonDanisch commented 3 years ago

any solution for this? I'm using now a separate script to run this command, but that's a bit ugly ;)

aminya commented 3 years ago

@SimonDanisch don't use this action which is broken.

Directly use xvfb-run from this script that I wrote for Plots.jl

https://github.com/JuliaPlots/Plots.jl/blob/9fc1d574cdd575946b4989a94f793f2be1e674ec/.github/workflows/ci.yml#L61-L66

SimonDanisch commented 3 years ago

Yeah I do ;) I just run into a problem recently when github upgraded the linux distro. Also, multiple os are a pain to handle like that - which sounds like the perfect job for a gh-action maintained by multiple people!