GabrielBB / xvfb-action

Run your tests headlessly ❌🖥️
https://github.com/marketplace/actions/gabrielbb-xvfb-action
MIT License
140 stars 20 forks source link

Node.js 12 actions are deprecated. #30

Closed unional closed 1 year ago

unional commented 1 year ago

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: GabrielBB/xvfb-action

tlambert03 commented 1 year ago

hey @GabrielBB ... Just checking in. Are you still maintaining this? or should we look into a fork for node16?

alisonatwork commented 1 year ago

After a couple months of no feedback on this ticket, I tried to find another way to fix this, and the good news is that the ubuntu-latest image now includes xvfb-run so there is no need to overlay this image any more.

See this PR for how I fixed it for the amVim VS Code extension: https://github.com/aioutecism/amVim-for-VSCode/pull/315

ssbarnea commented 1 year ago

As the maintenance status of this extension is under question, you might want to switch to https://github.com/coactions/setup-xvfb (fork) which already sorted this issue.

laeubi commented 1 year ago

Any update on this?

ssbarnea commented 1 year ago

@laeubi That is why I forked it under https://github.com/coactions/setup-xvfb so we can continue maintaining it as a community. GH is full of orphan projects and most of them are under personal accounts.

GabrielBB commented 1 year ago

Thank you so much @ssbarnea . I updated my README to notify deprecation and link to the new repo. I'll be closing this issue as the new repo solves it already

ssbarnea commented 1 year ago

@GabrielBB Thanks. If you want I am more than happy to also invite you as a maintainer to the repo. My hopes was to promote the coactions to others, so we can lower the maintenance burden but I never had time to do PR for that.

GabrielBB commented 1 year ago

@ssbarnea Okay, you can invite me. Do you know why the "contributors" section is not showing there? like it's shown here:

image