search

GabrielBB / xvfb-action

Run your tests headlessly ❌🖥️
https://github.com/marketplace/actions/gabrielbb-xvfb-action
MIT License
140 stars 20 forks source link

Update node to 16 #31

Closed hankolsen closed 1 year ago

hankolsen commented 1 year ago

Update action.yml to use node 16. Solves #30

julianhille commented 1 year ago

Until this is merged and to get rid of the deprecation message one could replace GabrielBB/xvfb-action@v1 with hankolsen/xvfb-action@dcb076c1c3802845f73bb6fe14a009d8d3377255

booo commented 1 year ago

I would appreciate a new release with this fix in it.

julianhille commented 1 year ago

Me too.

alisonatwork commented 1 year ago

I posted another possible solution for this on #30 - since the ubuntu-latest image now has xvfb-run inside it, you can probably skip this project altogether and just run your tests in the regular Linux container.

booo commented 1 year ago

@alisonatwork thanks for pointing out this fix! I will implement this in our project.

julianhille commented 1 year ago

I posted another possible solution for this on #30 - since the ubuntu-latest image now has xvfb-run inside it, you can probably skip this project altogether and just run your tests in the regular Linux container.

just want to point out that this might not be a solution for all, as ubuntu-latest brings a new glibc / libc with it and so raises libc requirements for compiled binaries. May need splitting compiling and testing onto two different machines in different build steps.

Just realised it when i wanted to start to update to this solution.

GabrielBB commented 1 year ago

Thank you. But this repo is now deprecated, please switch to: https://github.com/coactions/setup-xvfb