GabrielDosReis / ipr

Compiler-neutral Internal Program Representation for C++
BSD 3-Clause "New" or "Revised" License
221 stars 23 forks source link

What is the role of Binary? #258

Closed Xazax-hun closed 2 years ago

Xazax-hun commented 2 years ago

After https://github.com/GabrielDosReis/ipr/commit/802c786418ab9104d9e348756cc36487f7ad059f, Handler is no longer Binary, but its interface still has only two getters. We had some code that relied on some nodes being Binary so we can reduce the amount of code we need to write by utilizing the more regular structure of IPR. Does this mean we should no longer rely on nodes being Binary or Unary but call the specific getters directly? (Instead of using first/second in generic code.)