search

GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
197 stars 58 forks source link

Rancher not picking up dropped items[BUG] #335

Closed zombiehunternr1 closed 3 years ago

zombiehunternr1 commented 3 years ago

In the 1.17.1 version of this mod when I use a sword inside the Rancher it kills the adult mobs but leaves the dropped items on the floor. I've seen in older versions this would've automatically been picked up.

Steps to Reproduce:

I hope with the photo's this gives enough information about the issue.

Technical Information:

SplendidAlakey commented 3 years ago

Could you pinpoint the exact steps to reproduce this? It's been inconsistent for a very long time, but I've never been able to 100% reproduce this. I'm currently using 1.11.0-alpha.3 and it picks up almost everything, but sometimes still leaves items on the ground until they disappear.

zombiehunternr1 commented 3 years ago

The images with description are the exact steps to reproduce it. I don't know how else you want me to explain it.

SplendidAlakey commented 3 years ago

I mean like your full mod list and precise steps, not just "place a sword in" and "set to kill after 1". If I do just that, my machines pick stuff up just fine. But sometimes when I go away, the chunk unloads, then I come back, and the machines don't work. Sometimes it's the opposite. Also server restarts seem to occasionally interrupt the process until I take out the input items and place them back and/or resets the settings for "feed babies" and "kill after" to its defaults. But I can't pinpoint the exact steps to consistently reproduce this.

zombiehunternr1 commented 3 years ago

Okey, well here is a list of all the mods I've got running: 1 2 3 4 5

As for server stuff, I'm running this in my single player world on my pc and always stayed within the chunk while testing it.

If there is anything more you'll need let me know.

SplendidAlakey commented 3 years ago

I run almost all the mods you do, so they shouldn't be a problem. And since you are playing on a SP world I can't think of much else that could help you, sorry.

And FYI I'm not a contributor here, I've just been having the same issue on and off since, I think, 1.10.0-alpha.7, but could never find a way to consistently replicate it. So I thought maybe your experience could shed more light on it, but I personally don't see anything wrong with your setup. The only difference in mine is that I put my machines in the middle, but that shouldn't matter at all, as long as the loot is within the radius.

Try using the latest version, which is 1.11.0-alpha.3 and see if it's any better. Ignore that, I see that you are already using it, but in your initial post you wrote "1.10.0-alpha.12".

zombiehunternr1 commented 3 years ago

Yeah I thought updating it might've fixed it. Maybe I'll try the 1.10.0-alpha.7 version. If that one works I'll keep using that one.

SplendidAlakey commented 3 years ago

1.10.0-alpha.7 is not compatible with 1.17.1.

zombiehunternr1 commented 3 years ago

Oh thats the 1.16 verion then. Then idk maybe use the very first one for 1.17?

SplendidAlakey commented 3 years ago

No, it was the 1.17 version, which isn't compatible with 1.17.1.

zombiehunternr1 commented 3 years ago

Alright, then I'll try the first 1.17.1 release, see if that works.

SplendidAlakey commented 3 years ago

That would be 1.10.0-alpha.8. I don't think it will help, but I'll keep an eye on this thread in case you have any progress.

zombiehunternr1 commented 3 years ago

test So I thought I'd test this in a new world. When I first placed it and adjust the kill after amount it worked until the amount was reached. Then I placed in some more animals and it stopped picking up the items as you can see from this image.

SplendidAlakey commented 3 years ago

Yeah I tested it in SP too and it doesn't work there at all for me. Tested it with a Slaughter machine and that one picks up everything right away, so it's definitely an issue with the Rancher. In MP it sometimes picks everything up, sometimes nothing.

Did some more testing in MP and I noticed that if I never close the GUI of Rancher, it picks everything up as intended, but as soon as I close it, it becomes extremely inconsistent again.

SplendidAlakey commented 3 years ago

@zombiehunternr1 just letting you know that 1.11.0-alpha.4 was just uploaded to curseforge and the bug is fixed there. Note that the machine has to kill an entity in order for it to collect items, any items dropped manually or after killing an entity yourself will not be picked up.

GabrielOlvH commented 3 years ago

Indeed the update should fix the issue, thanks for reminding me to close open issues :p