GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
197 stars 58 forks source link

[BUG] Mining rig resource reports do not respect oregen.json #373

Closed broman closed 1 year ago

broman commented 2 years ago

Description:

Steps to Reproduce:

  1. Disable an ore in config/indrev/oregen.json
  2. Use the chunk scanner until you find a vein with the disabled ore
  3. Set up the mining rig
  4. Observe the disabled ore being extracted

Technical Information:

Logs:

Details:

broman commented 2 years ago

Also: If anybody has this exact issue and use AoF4 you can simply do a 1:1 conversion from Indrev's tungsten to the one that AoF4 uses. But this issue still persists with those who do not use AoF.

NiChrosia commented 2 years ago

One solution would be to add another config (utilizing the pre-existing one is a bad idea since it's for ore block gen rather than veins) (that would automatically generate entries for all vein types) and check whether the vein type is disabled before generating resources in the Mining Rig.

broman commented 1 year ago

Since the mining rig mechanics have since changed completely, and since this is taking up my github issues list, I'm closing it.

Thank you for making IndRev, I love this mod!