GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
196 stars 58 forks source link

[BUG] No super call in write and read nbt methods #452

Closed sleepy-evelyn closed 2 years ago

sleepy-evelyn commented 2 years ago

Description: There is no super call within the write or read nbt methods for block entities. This means if other mods want to add additional functionality to block entities within the world they can't.

At the moment i'm making a mod which allows block entities to be locked as the LockableContainer class is useless (most mods don't use it) this is the best method for this approach without implementing an entire database to log the position of different locked block entities.

Counter argument The counter argument is that you don't want other mods modifying anything about the block entities to prevent additional bug reports arriving. I kind of understand this but Industrial Revolution really is the only mod i've found that does this.