search

GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
196 stars 58 forks source link

Slaughter / Chopper Tech reborn support #454

Open aria1th opened 2 years ago

aria1th commented 2 years ago

allows usage of energy based items Those items can't extract energy, so it should use SimpleBatteryItem.tryUseEnergy()

aria1th commented 2 years ago

Well, it defines getEnergyMaxOutput as 0, so extract() does nothing... (or is there any other reason?) It has already done with EnergyStorage.ITEM.find(itemStack, ContainerItemContext.withInitial(itemStack)) but it does not return null, it finds : but it can't extract and the only way to decrement its energy is with extract externally

Technici4n commented 2 years ago

Sounds like it would maybe make more sense to allow these items to extract energy? Instead of bypassing an implementation detail?

aria1th commented 2 years ago

Yes, I'll try making pr in tech reborn side