search

GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
193 stars 56 forks source link

[BUG] Coal Generator continues to burn coal even when full. Making it quite difficut to use. #544

Closed douglasg14b closed 11 months ago

douglasg14b commented 11 months ago

Description:

The coal generator keeps on burning coal even when full. This means it always burns coal at the maximum speed, regardless of energy actually used.

This makes the bloc quite tedious and frustrating to use, as it takes the automation part of machines away since it requires babysitting to not chew through all your coal.

Steps to Reproduce:

  1. Use the coal generator
  2. Let it fill up
  3. Watch it keep burning all the coal that goes into it

Technical Information:

Logs:

No relevant logs, assumed this is a clogic bug

Details:

image\

The generator doesn't fill up all the way, and the code here means it just keeps on generating: https://github.com/GabrielOlvH/Industrial-Revolution/blob/012a1b83f39ab50a10d03ef3c1a8e2651e517053/src/main/kotlin/me/steven/indrev/blockentities/generators/SolidFuelGeneratorBlockEntity.kt#L22-L38

GabrielOlvH commented 11 months ago

Fixed as of 1.16.2, thanks for reporting.

douglasg14b commented 11 months ago

Thanks @GabrielOlvH!