GabrielOlvH / Industrial-Revolution

An Industrial mod made for Fabric.
Apache License 2.0
193 stars 56 forks source link

Update for Fabric 0.15.10, fixes server crash for 1.19.2. #586

Open Slayer5934 opened 2 months ago

EggTime commented 2 months ago

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI Description:

Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..). This only happens on a server, not a single player world.

Steps to Reproduce:

Open coal generator, solid infuser, etc.. with a GUI

Technical Information:

Minecraft: 1.19.2 Fabric API: 0.15.10 Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar Modpack: FTB Legend of the Eyes

Crashlog: https://pastebin.com/raw/1ReurQnp

Slayer5934 commented 2 months ago

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI Description:

Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..). This only happens on a server, not a single player world.

Steps to Reproduce:

Open coal generator, solid infuser, etc.. with a GUI

Technical Information:

Minecraft: 1.19.2 Fabric API: 0.15.10 Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar Modpack: FTB Legend of the Eyes

Crashlog: https://pastebin.com/raw/1ReurQnp

Hello, yes LibGui fork is also required to completely fix the issue. https://github.com/TeamChikken/LibGui-CHKNFork-1.19.2/releases/tag/1.19.2 Both of the mods would need to accept the proposed fixes (or fix them) for it to not crash, for now put but the fixed IndRev version and LibGui version in the mods folder.

EggTime commented 2 months ago

Heyo, thanks for the fix for fabric 0.15.10! However, I'm getting a server crash with this version when opening a GUI Description: Crashing when opening a gui from a machine (i.e., coal generator, solid infuser, etc..). This only happens on a server, not a single player world. Steps to Reproduce: Open coal generator, solid infuser, etc.. with a GUI Technical Information: Minecraft: 1.19.2 Fabric API: 0.15.10 Server Launcher Jar: fabric-server-mc.1.19.2-loader.0.15.10-launcher.1.0.1.jar Industrial Revolution: indrev-1.15.2-BETA-fab15hotfix.jar Modpack: FTB Legend of the Eyes Crashlog: https://pastebin.com/raw/1ReurQnp

Hello, yes LibGui fork is also required to completely fix the issue. https://github.com/TeamChikken/LibGui-CHKNFork-1.19.2/releases/tag/1.19.2 Both of the mods would need to accept the proposed fixes (or fix them) for it to not crash, for now put but the fixed IndRev version and LibGui version in the mods folder.

Fix works! except crashes with the Modular Workbench

Crash Report: https://pastebin.com/raw/ZLK8qr98

I saw pull request 583 fixes it, maybe see if merging the branches works?

Slayer5934 commented 2 months ago

That fix is already applied, something else is going wrong and ill have to look into it Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

EggTime commented 2 months ago

That fix is already applied, something else is going wrong and ill have to look into it Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

Heyo, It would just happen when I right clicked the workbench. I'm using the FTB Legend of the Eyes modpack. I did add a couple other mods that only deal with worldgen (but nothing with GUIs, so I doubt they are the issue).

Here's the crashlog for when I just did it again. https://pastebin.com/raw/Xh3M60z5

wyatt-herkamp commented 2 months ago
    repositories {
        maven {
            url "https://maven.cafeteria.dev/releases"
            credentials {
                if (project.hasProperty("mcdUsername") && project.hasProperty("mcdPassword")) {
                    username = project.property("mcdUsername")
                    password = project.property("mcdPassword")
                }
            }
            authentication {
                basic(BasicAuthentication)
            }
        }
    }

You can use this to prevent the Gradle error about missing properties while keeping the ability for the owner to publish to that repository.

Slayer5934 commented 2 weeks ago

That fix is already applied, something else is going wrong and ill have to look into it Edit: Could you give information on how it crashes? I tested in my modpack and it doesn't seem to crash when opening the menu

Heyo, It would just happen when I right clicked the workbench. I'm using the FTB Legend of the Eyes modpack. I did add a couple other mods that only deal with worldgen (but nothing with GUIs, so I doubt they are the issue).

Here's the crashlog for when I just did it again. https://pastebin.com/raw/Xh3M60z5

Hey this should be fixed now, to be honest the mod needs some more serious work on it, but the crashes for modular bench and rancher are fixed now.