some small improvements

GabrielTavernini / Covid19Stats

A simple mobile app developed with Flutter to visualize Covid19 statistics 🦠

GNU General Public License v3.0

144 stars 38 forks source link

some small improvements #7

Open DJCrashdummy opened 4 years ago

DJCrashdummy commented 4 years ago

[ ] it would be nice to add the ability to set a persistent default country, which perhaps also loads the charts by default.
[ ] if a default country is chosen, a simple button in the top bar to quickly switch between the default country and the global stats may be interesting.
[ ] also the possibility to mark more than one country as favorites, which are e.g. shown on the top of the select page may be interesting. - especially if you live in a smaller country or near a border and regularly want to check the situation around your own country.
[x] also the possibility to set the default view (total|daily) for the charts may be interesting. - because in some countries resp. after some time the total chart does not change that much.
[x] the icing on the cake would be to use separators for the numbers according to the devices regional settings(!) to grasp them more easily.

GabrielTavernini commented 4 years ago

I don't have much time to work on this project right now, but as soon as school and exams are over I'll try to implement some of the proposed features.

In the meantime, feel free to submit pull requests for any of those features. I'll try to be as quick as possible to review and merge them.

DJCrashdummy commented 4 years ago

I don't have much time to work on this project right now, but as soon as school and exams are over I'll try to implement some of the proposed features.

no pressure! these are just some suggestions which came into my mind while trying your nice app. - take the time you need to study and pass your exams... best wishes to you! :crossed_fingers:

In the meantime, feel free to submit pull requests for any of those features. I'll try to be as quick as possible to review and merge them.

besides i'm also really busy the last weeks (hence the late reply - sorry!), i'm unfortunately not really a dev, i'm just a bug hunter and only writing & fiddling around with scripts. :unamused: else i'm a FOSS enthusiast, and thankful that skilled devs like you write awesome FOSS... thank you! :clap:

GabrielTavernini commented 4 years ago

I wanted to let you know that in the latest release (2.0) separators have been added and going forward I'll try to implement some of the other features that you suggested.

WildOrangutan commented 4 years ago

I may leave you a PR or two, if you don't mind. Are you currently working on any of these features?

GabrielTavernini commented 4 years ago

Pull requests are more than welcome, feel free to do as many as you want. At the moment I'm not working on any of those features. I've added the button for a setting page but I didn't have time to add any of the features.

Months ago I thought about how to implement these features and my idea was to have the default country and view fields in the settings page, and the ability to set favorites in the country selection page (maybe activated by a floating button). Anyway, feel free to do whatever you think is better and let me know if you have any questions about the code.

WildOrangutan commented 4 years ago

Ok, I will start by adding two minor features:

Add selected country persistence, so previously selected country is saved between app restarts
Load chars by default