search

Gabriella439 / Haskell-Index-Core-Library

Indexed Types
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

AMP warning eliminated #1

Closed ggreif closed 10 years ago

Gabriella439 commented 10 years ago

I prefer not to add a .gitignore file for anything other than project-specific ignores (i.e. dist). General editor ignores should be in the user's git config.

Also, I don't want to unnecesarily impose a lower bound on base of 4.7 (because then I won't be able to compile it). I also don't think it should be necessary to change the lower bound.

ggreif commented 10 years ago

okay, let me rework...

Also I think the version should be 1.0.2 (edit: was 1.0.1) as I did not remove anything.

Cheers!

Gabor

On 4/30/14, Gabriel Gonzalez notifications@github.com wrote:

I prefer not to add a .gitignore file for anything other than project-specific ignores (i.e. dist). General editor ignores should be in the user's git config.

Also, I don't want to unnecesarily impose a lower bound on base of 4.7 (because then I won't be able to compile it). I also don't think it should be necessary to change the lower bound.

Reply to this email directly or view it on GitHub: https://github.com/Gabriel439/Haskell-Index-Core-Library/pull/1#issuecomment-41846372

ggreif commented 10 years ago

I have corrected my mistakes, do you prefer the commits squashed?

Gabriella439 commented 10 years ago

Don't worry! You don't need to squash the commits. :) I don't mind if the commit history is messy.

Is the increased lower bound for Cabal necessary?

Also, you can make the version number 1.0.2 since this is not really a breaking change. Some people treat additional type class instances as requiring a major version bump, but I don't.

ggreif commented 10 years ago

On 4/30/14, Gabriel Gonzalez notifications@github.com wrote:

Don't worry! You don't need to squash the commits. :) I don't mind if the commit history is messy.

Is the increased lower bound for Cabal necessary?

reverted.

Also, you can make the version number 1.0.2 since this is not really a

done.

breaking change. Some people treat additional type class instances as requiring a major version bump, but I don't.

Reply to this email directly or view it on GitHub: https://github.com/Gabriel439/Haskell-Index-Core-Library/pull/1#issuecomment-41855668

Gabriella439 commented 10 years ago

Looks good! Thank you so much! :)