Gabriella439 / Haskell-MMorph-Library

Monad morphisms
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Module ‘Control.Monad.Trans.Error’ is deprecated #17

Closed andreasabel closed 3 years ago

andreasabel commented 9 years ago

Probably you are aware of this already, but for me it stops me from using your library (and other libraries that depend on yours).

[1 of 2] Compiling Control.Monad.Morph ( src/Control/Monad/Morph.hs, dist/build/Control/Monad/Morph.o )

src/Control/Monad/Morph.hs:76:1: Warning:
    Module ‘Control.Monad.Trans.Error’ is deprecated:
      Use Control.Monad.Trans.Except instead

src/Control/Monad/Morph.hs:116:20: Warning:
    In the use of type constructor or class ‘E.ErrorT’
    (imported from Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"
Gabriella439 commented 9 years ago

Could you submit a pull request to delete all ErrorT-related instances?

bergmark commented 9 years ago

Why does this stop you from using it?

I would recommend to keep these instances for anyone who is still using ErrorT.

Gabriella439 commented 9 years ago

They will have to either be deleted or guarded with #ifdef statements eventually when transformers deletes ErrorT, but I can hold onto them for now.

turion commented 3 years ago

I would recommend to keep these instances for anyone who is still using ErrorT.

They throw warnings and thus make the dependency mmorph a nuisance when compiling with -Werror.