Gabriella439 / Haskell-MMorph-Library

Monad morphisms
BSD 3-Clause "New" or "Revised" License
47 stars 26 forks source link

Restore missing `Traversable` instance #58

Closed Gabriella439 closed 3 years ago

Gabriella439 commented 3 years ago

… as caught by @phadej in #57

This instance was omitted by mistake when refactoring the Control.Monad.Trans.Compose module to use GeneralizedNewtypeDeriving in #52

phadej commented 3 years ago

I'd also note that GND is not Safe Haskell. Check

I'm not sure what your take on Safe Haskell, but I'm almost sure someone relies on mmorph being Safe.

Maybe a good idea to explicitly mark the main module as Safe and Compose module as Trustworthy.

Sorry for the flood of suggestions.

Gabriella439 commented 3 years ago

@phadej: Alright, I'll mark it Trustworthy in a separate pull request

phadej commented 3 years ago

@Gabriel439 thanks!

Gabriella439 commented 3 years ago

You're welcome! 🙂