search

Gabriella439 / Haskell-Pipes-Safe-Library

Safety for the pipes ecosystem
BSD 3-Clause "New" or "Revised" License
26 stars 21 forks source link

CI with GitHub Actions #50

Closed chris-martin closed 2 years ago

chris-martin commented 2 years ago

The build matrix tests all the supported GHC versions, based on the supported versions of base given in the cabal file.

I like to test with cabal file for each build so that I can put in constraints to ensure that the CI is testing as many versions that the cabal file declares to be in bounds as possible. I haven't done that very much here, but I have put in constraints for the oldest build to test minimum bounds. The second commit raises the minimum bounds to reflect what is actually testable with GHC 7.10. Anyway, those are just my preferences, but thought I'd offer.

chris-martin commented 2 years ago

Should raise the base lower bound accordingly?

Gabriella439 commented 2 years ago

Yeah, that would be good to do, too

chris-martin commented 2 years ago

Updated. Minimum supported GHC version is 8.10. With the other dependency bounds raised accordingly, all CPP and cabal conditionals are now obviated. Made a few other tweaks so the package builds without warnings.