search

Gabriella439 / pipes-platform

The full ecosystem of pipes libraries
BSD 3-Clause "New" or "Revised" License
4 stars 2 forks source link

cabal-meta issues #1

Closed tonyday567 closed 11 years ago

tonyday567 commented 11 years ago

Some (good) cabal-meta advises:

The 'license' field is missing or specified as AllRightsReserved. 'ghc-options: -Wall -Werror' makes the package very easy to break with future GHC versions because new GHC versions often add new warnings. Use just 'ghc-options: -Wall' instead. 'hs-source-dirs: src' directory does not exist. Distribution quality warnings: 'ghc-options: -O2' is rarely needed. Check that it is giving a real benefit and not just imposing longer compile times on your users. Note: the public hackage server would reject this package.

  1. -O2 is ok?
  2. Any thoughts on licencing across the platform?
k0001 commented 11 years ago
  1. -O2 is ok?

I just checked bytestring, text, containers and vector, and all of them have ghc-options: -O2 in their .cabal files. I guess it's safe to do whatever they do. Also, I'm OK with dropping -Werror.

  1. Any thoughts on licencing across the platform?

BSD3 is the license most widely used throughout the entire Haskell ecosystem, so I think that's a safe choice if we want to play well with the rest of Haskell.

tonyday567 commented 11 years ago

G will need to hook up travis again, so I'll just push these through and close for now.