search

Gabriella439 / pipes

Compositional pipelines
BSD 3-Clause "New" or "Revised" License
489 stars 72 forks source link

Add conditional compilation of a pipes subset to Haskell98. #103

Closed archblob closed 10 years ago

archblob commented 10 years ago

I gave #102 a try.

I don't really like testing for #ifdef MIN_VERSION_packagename because it doesn't say anything to someone reading the code.

I would preffer if we could test for something like #if !haskell98 , what do you think?

At first I thought that cabal will include the symbol defined by Flag in the auto generated header file but it does not. So the only good alternative would be to include our header file with our custom symbol defined.

Please tell me if this is what you wanted and if i've done it right. :-P

Thank you.

archblob commented 10 years ago

It can be done without an additional header file, I will amend the comit.

archblob commented 10 years ago

I have also modified the export list by using the comma at the start of the line in a couple of modules, this way the lines are independent of the previous line and can be easily cut in preprocessing stage without having to do things like , expName , at the boundries.

I did not reorder anything to reduce the use of pragmas.

Gabriella439 commented 10 years ago

Yeah, I don't mind the prefix commas on import lists. I think it looks nicer that way.

Gabriella439 commented 10 years ago

Thank you for contributing this! You did a really excellent job and I couldn't find any problems (other than my question about the Enumerable instance for ErrorT).

archblob commented 10 years ago

I'm glad I could help, it was a good learning experience.