search

Gabriella439 / pipes

Compositional pipelines
BSD 3-Clause "New" or "Revised" License
487 stars 72 forks source link

Support GHC 8.8 #199

Closed fumieval closed 5 years ago

fumieval commented 5 years ago

Pardon an automatically-posted pull request; this is a part of Operation Vanguard. Note that this does not guarantee that tests and benchmarks are buildable.

Gabriella439 commented 5 years ago

@fumieval: It looks like this somehow generated a very large diff for the pipes.cabal file even though it looks like very little changed

fumieval commented 5 years ago

The content was messed up for some reason. I removed the change

Gabriella439 commented 5 years ago

@fumieval: I believe this requires a conditional dependency on fail for older versions of GHC in order to build on pre-GHC-8. i.e.:

if impl(ghc < 8.0):
  build-depends: fail == 4.9.*
fumieval commented 5 years ago

That's right, added in e1d888d

Gabriella439 commented 5 years ago

This is superseded by #203