Pipes.Prelude benchmarks feedback.

[Gabriella439]

Awesome! I'll go ahead and merge this in. Thanks so much for contributing this!

[archblob]

Well, it was not my intention for you to merge this seeing as it's not all of Pipes.Prelude, after your feedback I wanted to complete it, squash all the commits and reopen a clean pull request. :-P

[Gabriella439]

Oops! I'm sorry about that. :)

I will give you some feedback then later today and we can improve on it.

[Gabriella439]

Ok, here are some comments that I have as I go through your code:

• Is there any reason why there are two modules for the benchmarks?
• Combine run . (discard <\\) into a single function:

    drain p = run (for p discard)

• Compare the performance ofeach vs enumFromTo. That's one of the more important benchmarks.
• In some places you use runIdentity before using whnf and in other places you don't
• Four-space indentation is a little more readable
• Put bounds on the dependencies. At least lower bounds, to prevent people from accidentally installing pipes-3.
• Find the lowest version of Cabal that supports benchmarking. I already lowered it to 1.14 because that's the one I have installed, but maybe it can go even lower.

Again, I'm sorry about prematurely merging in your work. If you open up a new pull request with any additional changes I won't merge it in until we both agree it is ready.