Overall good job with the Flixster Project. The core functionality works great and the overall aesthetic of the website seems to flow smoothly. Good job on implementing all the core features and hitting the stretch goals as well! One small general feedback, I'd recommend to have the deployed version of the website reflect the latest changes in the repository.
Features Feedback
In the Load More button/Search queries, you catch the error, if no data is returned. However, this should impact the functionality of each button. For example, if there are no more movies to Load, what is the purpose of the Load More button? (i.e. when searching for a specific movie)
The filter functionality should work independently from the other buttons and other filters. It should be possible to add multiple filters (such as two genres), or when on the Now Playing field, when you add the filter, it would be expected to filter only now playing movies. How is this different from what is currently being done?
More of a smaller issue, It would be helpful for the user (and in the future) to understand which filters are currently being applied.
Code Feedback
The Liked vs Watched list of movies share similar functionality. For consistency, is it possible to make this more modular toggle functions when a new movie is liked/watched? Also, can we make the display of each list more consistent?
For each Movie Panel you have to click out the X button to go back to the main page. For functionality purposes could it possible to make the Movie Panel a panel you can click out of, or possible have the X button persist through scrolling (using position: fixed; in button class). In its current state it is unintuitive how to escape the panel after scrolling down
Feedback
Overall good job with the Flixster Project. The core functionality works great and the overall aesthetic of the website seems to flow smoothly. Good job on implementing all the core features and hitting the stretch goals as well! One small general feedback, I'd recommend to have the deployed version of the website reflect the latest changes in the repository.
Features Feedback
In the Load More button/Search queries, you catch the error, if no data is returned. However, this should impact the functionality of each button. For example, if there are no more movies to Load, what is the purpose of the Load More button? (i.e. when searching for a specific movie)
The filter functionality should work independently from the other buttons and other filters. It should be possible to add multiple filters (such as two genres), or when on the Now Playing field, when you add the filter, it would be expected to filter only now playing movies. How is this different from what is currently being done?
More of a smaller issue, It would be helpful for the user (and in the future) to understand which filters are currently being applied.
Code Feedback
The Liked vs Watched list of movies share similar functionality. For consistency, is it possible to make this more modular toggle functions when a new movie is liked/watched? Also, can we make the display of each list more consistent?
For each Movie Panel you have to click out the X button to go back to the main page. For functionality purposes could it possible to make the Movie Panel a panel you can click out of, or possible have the X button persist through scrolling (using
position: fixed;in button class). In its current state it is unintuitive how to escape the panel after scrolling down