search

Gabrock94 / pyaesthetics

A python package to extract visual features about the aesthetic appearance from still images.
GNU General Public License v3.0
34 stars 6 forks source link

Implementation plans for self-similarity #4

Open shunk031 opened 2 months ago

shunk031 commented 2 months ago

Hi @Gabrock94, thank you for the awesome repository.

Looing at this code, the implementation appears to be in progress. Are there any plans for future implementation?

Gabrock94 commented 2 months ago

Hi! Thanks for the feedback.

Looing at this code, the implementation appears to be in progress. Are there any plans for future implementation? Actually yes. The problem is that I haven't been able to implement it properly on my first try and later on I got distracted by other things. Now I am implementing a couple different things for shapes detection, which have priority as we are using it for a thesis project. I will try to finish the self similarity soon after.

I have also seen your fork/pull request. I will take a look at it in the coming days!

shunk031 commented 2 months ago

Thanks for the reply.

I have found the original paper and its Matlab code but am finding it a bit difficult to reproduce it. I wish you good luck with your thesis.

Furthermore, thanks for mentioning my fork. I am not sure if I should send a pull request as the changes are very large compared to your code (including a lot of formatting and refactoring according to Python's PEP8 rules).

Gabrock94 commented 2 months ago

I have found the original paper and its Matlab code but am finding it a bit difficult to reproduce it. I wish you good luck with your thesis.

Yes, the code is not very self explanatory. Maybe now with LLMs converting it will be easier.

Furthermore, thanks for mentioning my fork. I am not sure if I should send a pull request as the changes are very large compared to your code (including a lot of formatting and refactoring according to Python's PEP8 rules). I'll leave this for you to decide