search

GaeaKat / Thaumic_Exploration

Thaumic Exploration is a WIP add-on for Thaumcraft 4 that adds a variety of new content.
9 stars 10 forks source link

Fixed 'Everfull Urn' bug #38

Closed asleire closed 8 years ago

asleire commented 8 years ago

Everfull Urn will no longer remove damage value from handheld tanks such as Ender Tank and Portable Tanks causing them to convert into other items (Ender Chest and Creative Portable Tank)

GaeaKat commented 8 years ago

Can one of the admins verify this patch?

asleire commented 8 years ago

What admins? I found the bug report @ http://forum.feed-the-beast.com/threads/1-1-0-everfull-urn-creating-creative-portable-tanks.153801/ while looking for another bug, and thought I'd fix it.

GaeaKat commented 8 years ago

@Emaziz it is the jenkins asking if it is okay to test this PR

GaeaKat commented 8 years ago

ok to test

GaeaKat commented 8 years ago

Also please do not refactor code in PR's, keep the code changes only to what you state in the PR.

asleire commented 8 years ago

Thanks, I'll keep that in mind

asleire commented 8 years ago

I realized this fix adds unwanted behavior: Using stackable tanks fills the entire stack.

Will fix the fix and make new PR.

GaeaKat commented 8 years ago

That is why we didn't do it that way