Gaelmare / dynamictreestfc

Dynamic Trees and TFC!
MIT License
6 stars 9 forks source link

Can’t plant saplings from other addons in TFC soils #27

Closed supermassimo closed 4 years ago

supermassimo commented 4 years ago

This issue was posted in the Extra Compat repository but I’m moving it here as I think it’s more appropriate. https://github.com/supermassimo/DynamicTrees-ExC/issues/42

Comment from me: Solution is easy, You can check how my The Aether addon registers Aether soil for every tree in registry that allows grass. The BoP addon also does this.

Op posted: Other Dynamic Trees addons seem to work 💯 percent fine though.

Gaelmare commented 4 years ago

This one is already fixed and released, see commit https://github.com/Gaelmare/dynamictreestfc/commit/861fd6ca409599eb25b08436bf83e5c430765003

Could use an update from the original reporter. @Royal-Jelly

Royal-Jelly commented 4 years ago

I am in fact using the absolute latest version of dynamictreestfc which has been working as intended. I could remove dynamictreestfc and the issue still persists, I'm fairly certain the issue is not with the implementation of dynamictreestfc.

@supermassimo Sorry for not specifically mentioning before but, none of the seeds from the twilightforest module will plant for me.

I haven't tested your other dyntrees[modules] but i suspect that they may not plant on other soil types.

Royal-Jelly commented 4 years ago

Also ... sorry for unintentionally for wasting your time @Gaelmare, thank you for helping me clear up this misunderstanding.

Gaelmare commented 4 years ago

No Problem. The DTTFC addon registers TFC soils to every registered DT species. If the saplings aren't working, it could be that they weren't registered when the registerBlocks function was called in DTTFC. It may be an addon ordering issue. Not sure if that's the right time is to register additional acceptableSoil blocks?

Royal-Jelly commented 4 years ago

I was toying around with modlists and actually found something interesting @Gaelmare even without your DTTFC mod i have planted some addon trees on tfc soils