search

GafferHQ / dependencies

All 3rd party dependencies necessary for building Gaffer
33 stars 26 forks source link

OpenPGL : Add Path-guiding for Cycles #232

Closed boberfly closed 1 year ago

boberfly commented 1 year ago

Applied over the top of: https://github.com/GafferHQ/dependencies/pull/230 so it's probably for after this lands.

Entirely optional for Cycles but nice to have.

johnhaddon commented 1 year ago

Thanks Alex - seems worthwhile to get this into Gaffer 1.3. Will there be much work needed for it on the Gaffer side?

boberfly commented 1 year ago

@johnhaddon I've got the changes here: https://github.com/boberfly/gaffer/commit/df1ea4696c926bcc92fdd81013054b9adffcaabd but I left out the linking library and the pre-processor define as I was waiting on your response if we could land this for 1.3 :)

boberfly commented 1 year ago

I also have OpenImageDenoise but that requires ISPC and I'm not sure how we want to deal with that (currently I download their binary directly in a dependency ISPC/config.py).

johnhaddon commented 1 year ago

Rebased to fix merge conflicts, and merging...