search

GafferHQ / dependencies

All 3rd party dependencies necessary for building Gaffer
33 stars 26 forks source link

OpenImageDenoise + ISPC added #239

Open boberfly opened 1 year ago

boberfly commented 1 year ago

Just leaving this here if we want to get this up and running for Cycles - I had ISPC included in the bin/ manifest for some MoonRay experiments as that renderer uses it like a shader compiler, but I kept it out of this PR as it isn't needed to be packaged with Gaffer, only to build OpenImageDenoise.

Realistically it probably would make sense to leave ISPC as a prerequisite for the host's building environment instead of making it a package, open to suggestions...

johnhaddon commented 1 year ago

Realistically it probably would make sense to leave ISPC as a prerequisite for the host's building environment instead of making it a package

Agreed. Unless we need it at runtime, it should be something we add to the build container. I see its BSD licensed, so that shouldn't be a problem to do that.