GafferHQ / gaffer

Gaffer is a node-based application for lookdev, lighting and automation
http://www.gafferhq.org
BSD 3-Clause "New" or "Revised" License
951 stars 206 forks source link

Reveal Source in Graph Editor #3043

Closed andrewkaufman closed 2 months ago

andrewkaufman commented 5 years ago

To view where in the Graph Editor an object has been created some people do the following.

Driving this directly from the Viewer is likely tricky with multiple Graph Editors, but having some means of quickly finding where in the graph the object or its tweaks are located seems like a handy workflow.

Perhaps drag & drop would be suitable (and should work from the Scene Hierarchy as well).

johnhaddon commented 5 years ago

Perhaps drag & drop would be suitable (and should work from the Scene Hierarchy as well).

I started looking into this, and I'm a little reluctant. To implement it, we need to connect to dragEnterSignal() on the GraphEditor, and at that point compute the source node, to determine whether or not we can accept the drag, and to change the pointer icon etc. While in the majority of cases that will be so quick you don't notice, its possible that it will trigger an arbitrarily expensive compute, and I don't think that's an acceptable side effect of an otherwise casual interaction, and it's not something that makes sense to launch asycnronously.

I was asked this by an artist the other day actually, and I showed them that they could drag&drop any plug label from the NodeEditor into the GraphEditor to centre on that node. This seems more direct than the bookmarking approach described above, but was still unintuitive. We discussed that a more intuitive interaction might be to drag&drop the node name label from the top of the NodeEditor into the GraphEditor. Perhaps that would be enough?

johnhaddon commented 2 months ago

Closing - this was done in 1.4.0.0 :

  • GraphEditor : The source node for any location can be located by dragging the location into the GraphEditor from the Viewer or HierarchyView.