GafferHQ / gaffer

Gaffer is a node-based application for lookdev, lighting and automation
http://www.gafferhq.org
BSD 3-Clause "New" or "Revised" License
930 stars 206 forks source link

Add default metadatas to EXRs from 3Delight #5777

Open vNicolini opened 3 months ago

vNicolini commented 3 months ago

Summary

Add default metadatas to EXRs from 3Delight similarly to the ones already available in Arnold's render outputs.

What

Add metadatas related to the following:

Why

It's really handy to do r&d and profiling in regard to rendering in general, would also provide additionnal, useful information in turntables/slapcomps, etc ....

See EXRs attached that demonstrate current default EXR metadatas of Arnold compared to 3Delight's EXRs_exemples.zip

gkocov commented 3 months ago

Per the NSI specs embedding render stats data to the rendered image file is done using an int embedstatistics outputdriver attribute. Adding a bool/int embedstatistics custom output parameter in a Gaffer Outputs node correctly creates the corresponding NSI outputdriver attribute, but when checking the rendered EXR image metadata I couldn't find any render stats metadata being added. I even tried exporting the NSI scene file from Gaffer and then rendering it in the shell with renderdl -stats which should force adding the render stats metadata, but still without results. I don't think Gaffer is doing anything wrong here, so it might be best to check with the 3DL devs regards this.