Gagravarr
commented
9 years ago Few bits:
- I'm trying to move to the same code formatting rules as Apache Tika does. This seems to reformat/re-indent a whole bunch, in a different way, and makes comparing changes tough :/
- I'm not sure that OpusCommentTool is the right place for outputting much of this info. I think it belongs in a new tool, OpusInfoTool (following the model of others)
- Needs unit tests
- I do, however, like the idea of pulling out more info like this!
Given the stream reset issue, maybe the answer is to have another class / method to cover the functionality of updateInfoFromStream, then have the new OpusInfoTool call out to that. That way, people wanting other functionality don't have to worry about the mark/reset while this info is calculated, since they won't calculate it, but people who do want it (eg OpusInfoTool) can call to it?
andrm
More information about Opus streams implemented. I know it's quite a lot of changes, but hopefully you can review it and incorporate them into VorbisJava. Comments, hints, bug reports welcome!
I pretty much did what info_opus.c in the opus-tools-0.1.9 does. Multiple opus streams are not supported right now.
I changed OggFile/OggPacketReader so it can be reset to the position before the info extraction. OpusInfo needs to read the entire stream for its work.
The frame check is removed in this pull request.