Gagravarr / VorbisJava

A library for working with Ogg Vorbis files
Apache License 2.0
128 stars 26 forks source link

Weird <scope> associated to vorbis-java-core tests in vorbis-java-tika #2

Closed tmortagne closed 10 years ago

tmortagne commented 11 years ago

Here is how the dependencu is declared:

<dependency>
  <groupId>${project.groupId}</groupId>
  <artifactId>vorbis-java-core</artifactId>
  <version>${project.version}</version>
  <classifier>tests</classifier>
  <scope>test,provided</scope>
</dependency>

It's the first time I see such a multiple scope.

Among other things it make the Maven WAR plugin include this dependency as if it was a build scope dependency.

I don't know if this worked in old version of Maven but org.apache.maven.model.Dependency has only one scope for sure.

Gagravarr commented 11 years ago

What would you suggest changing it to? (I know enough maven to be dangerous, but certainly not enough to get everything right!)

tmortagne commented 11 years ago

What is the goal ?

Gagravarr commented 11 years ago

The idea is to mark the vorbis-java-core test package as being needed when unit testing the vorbis-java-tika package, without vorbis-java-core test being included as a downstream dependency of vorbis-java-tika, and marking the test package as being already supplied (much as the main vorbis-java-core jar is). Is there a different scope to use to mark the dependency such?

tmortagne commented 11 years ago

Did you tried with just test ? As far as I know test dependencies are not included in transitive dependencies anyway.

mflorea commented 10 years ago

Isn't this fixed by e8b27588021b5ad5b7117affaf6a6e2d79be5567

tmortagne commented 10 years ago

Yes seems to be fixed in 0.2 but 0.2 is not in Maven central and Tika 1.5 that was released yesterday still depends on 0.1.

Gagravarr commented 10 years ago

I believe this is fixed in 0.3, which is present on Maven Central - any chance someone could check and confirm?

tmortagne commented 10 years ago

http://search.maven.org/remotecontent?filepath=org/gagravarr/vorbis-java-tika/0.3/vorbis-java-tika-0.3.pom is OK as far as I can see

Gagravarr commented 10 years ago

Great, thanks for you help. I've updated Tika to use 0.3, so hopefully it's all now fixed