Gagravarr / VorbisJava

A library for working with Ogg Vorbis files
Apache License 2.0
128 stars 26 forks source link

Circular dependencies with tika-core #24

Open michael-simons opened 6 years ago

michael-simons commented 6 years ago

Hi there, I'm using maven-enforcer-plugin to make sure I don't have mismatching dependencies in my build.

vorbis-java-tika depends on an outdated version of tika-core and pulling it in through tika-parsers leads to having a conflict between tika 1.17 and 1.12 currently.

ohne titel

Gagravarr commented 6 years ago

The Tika Core dependency is set to the oldest one that the code is able to work with, that way people stuck on older versions of Tika are still able to use the latest release.

If there's some Maven magic which better expresses "this is the oldest version you can work with and should be used at compile time, but newer versions should be used in preference", please let me know and I'll make the switch!

PandaMonkey commented 6 years ago

Hi, @michael-simons , there is a dependency conflict between tika-core 1.17 and 1.12 in your project now. Your project actually depends on tika-core 1.17, and if you plan to exclude the redundant version tika-core 1.12 which is transitivity introduced by vorbis-java-tika, you can add the following patch in your pom. Hope my answer really helps you.

    <dependency>
        <groupId>org.gagravarr</groupId>
        <artifactId>vorbis-java-tika</artifactId>
        <version>0.8</version>
        <exclusions>
            <exclusion>
        <groupId>org.apache.tika</groupId>
                <artifactId>tika-core</artifactId>                                    
            </exclusion>
        </exclusions>
    </dependency>
michael-simons commented 6 years ago

Thanks a lot @PandaMonkey That's what I applied. Much appreciated!