search

Gagravarr / VorbisJava

A library for working with Ogg Vorbis files
Apache License 2.0
126 stars 26 forks source link

Implement Closeable / AutoCloseable on various classes #8

Closed nguillaumin closed 10 years ago

nguillaumin commented 10 years ago

Hi,

Thanks for the library. It would be great if resources that can be closed (Such as VorbisFile) could implement java.io.Closeable or even better java.lang.AutoCloseable (Java 7 only though).

It would make it a lot easier to deal with them using Apache Commons-IO IOUtils.closeQuietly() or the try-with-resources pattern, rather having to nest multiple try/catch ...

Thanks,

Nico

Gagravarr commented 10 years ago

The library is used by Apache Tika, which is Java 1.6, so sadly Java 7 features are out

Implementing java.io.Closeable ought to be straightforward though

nguillaumin commented 10 years ago

Thanks!