Open gmichal opened 5 years ago
Hi! :) I couldn't reproduce your error. I'm working on with a linux os and not macOS, but I don't think that is the cause of difference.
Can you try to provide more details somehow? :) Are you running a clone of the most-updated master branch?
Same issue. Downloaded the latest zip file of the project on Mac. Opened terminal. sudo installed requests, pillow, tqdm. navigated to downloads folder inside the master folder. ran python download_archive.py .
l-230-169:ISIC-Archive-Downloader-master jayce$ python download_archive.py File "download_archive.py", line 93 def download_descriptions(ids: list, descs_dir: str, num_processes: int) -> list: ^ SyntaxError: invalid syntax
The arrow is actually pointing to the ids: Any help at all?
Having the same problem on Ubuntu Server. The error is pointing to ids.
I think I know what the issue might be. I think in newer versions of python the type 'list' is deprecated in favor of 'List' from the typing module.
On Tue, Jun 2, 2020, 19:55 Takeshi Sugiyama notifications@github.com wrote:
Having the same problem on Ubuntu Server. The error is pointing to ids.
[image: Screen Shot 2020-06-02 at 9 53 26 AM] https://user-images.githubusercontent.com/58148757/83547438-11091600-a4b7-11ea-9053-c6b374296904.png
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GalAvineri/ISIC-Archive-Downloader/issues/32#issuecomment-637679060, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUF4HHYJSQHYPBGOUXIEE3RUUVGHANCNFSM4I3PUHOA .
So fix will be to add
from typing import List
...
def download_description(ids: List, descs_sir: str, ...
Exactly. Thank you :) I also think there might be other places places where the same replacement is needed.
On Tue, Jun 9, 2020, 00:09 Jamil notifications@github.com wrote:
So fix will be to add
from typing import List ... def download_description(ids: List, descs_sir: str, ...
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GalAvineri/ISIC-Archive-Downloader/issues/32#issuecomment-640887991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFUF4HFTM5WHQ4YL4KQMZE3RVVHQTANCNFSM4I3PUHOA .
This is what I get when I try to run the script:
File "download_archive.py", line 93 def download_descriptions(ids: list, descs_dir: str, num_processes: int) -> list: ^ SyntaxError: invalid syntax
macOS Catalina Python 3.7.3