search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
224 stars 106 forks source link

TableScreen #1102

Closed jmeyers314 closed 3 years ago

jmeyers314 commented 3 years ago

This PR adds a new type of PhaseScreen for use with galsim.PhaseScreenPSF. It wraps a galsim.LookupTable2D to enable arbitrary user provided phases.

Note that I haven't paid super close attention yet to potential 90-degree rotations or flips of phase screen definitions here, or even in the past with AtmosphericScreens or OpticalScreens. I'd like to address this in a future issue though, after I've had a bit of time to investigate with batoid/Zemax things like is a +ve wavefront defined to be leading or lagging the reference sphere?, and make sure I got things right like is the FFT math consistent with viewing the focal plane from the front or from the back?

jmeyers314 commented 3 years ago

Thanks for the numpy hints. I think this is good to go now, unless you'd prefer to wait until I've investigated more on https://github.com/GalSim-developers/GalSim/issues/1104.

rmjarvis commented 3 years ago

Thanks Josh!