search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
227 stars 107 forks source link

Fix typo in GSFitsWCS #1136

Closed jmeyers314 closed 3 years ago

jmeyers314 commented 3 years ago

Ah, okay. What initially caught my eye was the duplicated np.array_equal(self.cd,other.cd) line. I guess I figured the duplication indicated something was missing instead of simply being superfluous. And now I see that yes, equal wcs_types implies equal projections, so long as one isn't directly manipulating attributes.

No need to complicate __eq__ and unit tests. I'll simplify this to a more cosmetic fix.

jmeyers314 commented 3 years ago

Self-review since now trivial.