GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
224 stars 105 forks source link

PhotonDCR config bugs #1148

Closed jmeyers314 closed 2 years ago

jmeyers314 commented 2 years ago

Placing here so I don't forget:

Looks like PhotonDCR._opt_params is missing an entry for obj_coord.

Also, there's a typo: zenit_coord -> zenith_coord.

Need to add some config usage tests.

rmjarvis commented 2 years ago

One comment about this. The zenit_coord is of course a typo-bug, which apparently isn't covered by unit tests. But obj_coord is handled by the PhotonDCRBuilder here: https://github.com/GalSim-developers/GalSim/blob/releases/2.3/galsim/config/photon_ops.py#L220

rmjarvis commented 2 years ago

Done via #1160