search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
224 stars 105 forks source link

Chromatic seeing when photon shooting #1225

Closed jmeyers314 closed 1 year ago

jmeyers314 commented 1 year ago

Adds chromatic seeing to atmospheric code for use when using geometric photon shooting (I believe similar behavior is already emergent when drawing with Fourier techniques).

To implement, I added a wavelength argument to the various wavefront_gradient methods. In retrospect, I maybe should only have added the extra argument to the private version _wavefront_gradient, since as a purely geometric object, the real wavefront gradient isn't wavelength dependent. Adding wavelength dependence here is kind of a hack to ensure we get the lambda^-beta chromatic dependence (beta ~ 0.2-0.4) expected from the fully diffractive calculation. But I could lean either way on this one so curious for feedback.

rmjarvis commented 1 year ago

I think we're abandoning this now, right? Since it didn't really work the way we expected.