search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
223 stars 105 forks source link

Optimize bits of HSM code #1279

Closed arunkannawadi closed 5 months ago

arunkannawadi commented 5 months ago

This PR addresses a lot of the concerns raised in #1264. I also separated conversion code from code that checks things as much as possible. I can add some additional unit tests if this all looks sensible.

arunkannawadi commented 5 months ago

OK, something completely unrelated seems to be failing. test_interpolateImage.py should set up some global variables but that don't seem to be recognized in the test cases. All tests pass locally on my machine.

rmjarvis commented 5 months ago

For now, just pin pytest to <8. They changed something with pytest v8 about how they run (or don't!) setup() before the tests functions. I haven't dug in to figure out what to change to make it work with v8 yet.

rmjarvis commented 5 months ago

Test suite looks good. Thanks.