Closed beckermr closed 4 months ago
@rmjarvis This one is ready for review!
Also, out of curiosity, what kind of logging do you use critical for? Error is already the maximum thing that I ever consider, since those are already ending the program. Critical seems like the same thing to me for anything I do.
Thanks @rmjarvis! I am using critical for some debugging. I won't be able to get to the CI changes here for a bit. Those should probably be a new PR anyways.
@rmjarvis I don't really understand codecov's failure here. I called the method and it is saying the actual logger call has been executed. However, it calls the if statement line partial. Any advice?
ok @rmjarvis this one is ready for review!
This method is missing and I happened to need it. Adding it here.