search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
228 stars 107 forks source link

ENH add critical logger method to logging wrapper #1287

Closed beckermr closed 6 months ago

beckermr commented 6 months ago

This method is missing and I happened to need it. Adding it here.

beckermr commented 6 months ago

@rmjarvis This one is ready for review!

rmjarvis commented 6 months ago

Also, out of curiosity, what kind of logging do you use critical for? Error is already the maximum thing that I ever consider, since those are already ending the program. Critical seems like the same thing to me for anything I do.

beckermr commented 6 months ago

Thanks @rmjarvis! I am using critical for some debugging. I won't be able to get to the CI changes here for a bit. Those should probably be a new PR anyways.

beckermr commented 6 months ago

@rmjarvis I don't really understand codecov's failure here. I called the method and it is saying the actual logger call has been executed. However, it calls the if statement line partial. Any advice?

beckermr commented 6 months ago

ok @rmjarvis this one is ready for review!