search

GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
223 stars 105 forks source link

Remove unused modules #1301

Closed AlexKurek closed 1 month ago

rmjarvis commented 1 month ago

This breaks the unit tests. Did you try running the tests yourself before submitting the PR?

AlexKurek commented 1 month ago

This breaks the unit tests. Did you try running the tests yourself before submitting the PR?

Not really, I didnt even know it is possible to run the test by myself (offline?). It seems I remove some actually needed module(s). Interesting that only MacOS test failed.

rmjarvis commented 1 month ago

Once one of them fails, the rest are canceled. That's standard GHA behavior. The MacOS run just happened to be the first one to get to the error.

And yes, you can run the tests yourself. Install the code on your branch. Then run pytest in the tests directory.

AlexKurek commented 1 month ago

I am not making much progress fixing this. Is it okay if I undo my changes and do it again, this time testing things locally?

rmjarvis commented 1 month ago

Is it okay if I undo my changes and do it again, this time testing things locally?

Sure.