GalSim-developers / GalSim

The modular galaxy image simulation toolkit. Documentation:
http://galsim-developers.github.io/GalSim/
Other
227 stars 107 forks source link

Adding trefoil to optical PSF #390

Closed HironaoMiyatake closed 11 years ago

HironaoMiyatake commented 11 years ago

There is a discrepancy between GalSim optical PSF based on 3rd order aberration and ZEMAX output. By comparing them by eyes and also from suggestions by DES optics people, adding trefoil to optical PSF might make the discrepancy small. The trefoil is the next order of spherical in Zernike polynomials;

rmjarvis commented 11 years ago

The trefoil for DES is huge, so that makes sense. Aaron Roodman goes up to Zernicke order 10 or 11, the last one being spherical, which I think we already have in OpticalPSF. Certainly trefoil is more important in the DES donuts than spherical, so if we include spherical, we should probably also include trefoil.

HironaoMiyatake commented 11 years ago

Yes, the trefoil is also huge for other cameras. I hope this will improve the approximation of realistic optics by the OpticalPSF.

On 2013/04/10, at 13:25, Mike Jarvis notifications@github.com wrote:

The trefoil for DES is huge, so that makes sense. Aaron Roodman goes up to Zernicke order 10 or 11, the last one being spherical, which I think we already have in OpticalPSF. Certainly trefoil is more important in the DES donuts than spherical, so if we include spherical, we should probably also include trefoil.

$B!=(B Reply to this email directly or view it on GitHub.

barnabytprowe commented 11 years ago

Agree, the trefoil was suggested on an email conversation with Hironao... And the suggestion came directly from eyeballing the ZEMAX model, seeing it looked like a Mercedes Benz sign, and from that conversation we had with Aaron Mike!

Best regards,

Barney

Barnaby Rowe Postdoctoral Research Associate

Department of Physics & Astronomy University College London Gower Street London WC1E 6BT United Kingdom

On 10 Apr 2013, at 10:32, Hironao Miyatake wrote:

Yes, the trefoil is also huge for other cameras. I hope this will improve the approximation of realistic optics by the OpticalPSF.

On 2013/04/10, at 13:25, Mike Jarvis notifications@github.com wrote:

The trefoil for DES is huge, so that makes sense. Aaron Roodman goes up to Zernicke order 10 or 11, the last one being spherical, which I think we already have in OpticalPSF. Certainly trefoil is more important in the DES donuts than spherical, so if we include spherical, we should probably also include trefoil.

$B!=(B Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

rmandelb commented 11 years ago

Closing #390.